improve: connection management and error handling #1986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection Management Refinements and Error Handling Improvements
This PR implements several key changes, include:
Enhanced Error Handling
Simplification and Refactoring
Connection::close
andConnection::accept
have been simplified and refactored for clarity.Precise Timeout Management
std::chrono::milliseconds
implemented for more accurate timeout settings.Improved Protocol Management
Robust Socket Closure
socket.cancel();
inConnection::closeSocket()
ensures cancellation of pending asynchronous operations, increasing safety during socket closure.Safe Message Sending
Optimized Thread Safety
std::scoped_lock
andstd::unique_lock
optimized for safer thread handling.Improved IP and Timeout Handling